Zara Zong

Results 10 comments of Zara Zong

Update - new implementation of `igraph_rich_club_density_sequence()` does the following: - gets list of edges from `graph` via `igraph_get_edgelist()` - loops through edgelist - for each edge, gets `edgeRemovalIndex` of whichever...

> I believe the inner loop can be eliminated: instead of incrementing `edgesRemainingAfter` in the `0..i` range, we just increment at `i`. When we're done, we accumulate from the end...

Thanks again for the detailed feedback - that's been _really_ helpful! I have a bit more on my plate today, but will get on this later tonight or tomorrow.

Added: - `totalPossibleEdges` for directed + loops cases: | | **no loops** | **loops** | | ----------- | ----------- | ---- | | **undirected** | $\frac{n(n-1)}{2}$ | $\frac{n(n+1)}{2}$ | |...

Commenting to say I saw this - working on it!

Updated: > * [x] Make sure the CI tests pass. > * [x] Remove `igraph_rich_club_coefficient()` completely from this PR. I'm thinking it's better if we finish the first function, merge...

added a few more tests for the weighted vs unweighted and loops vs no loops cases, and one for a weighted graph!

@szhorvat Thank you so much for all your guidance this past week - I have so much to learn both conceptually about graphs and about open-source contributing itself, but your...

Sidenote: I think the [link](https://igraph.org/c/pdf/latest/igraph-docs.pdf) to the PDF version of the documentation broke? This was linked from the [get started](https://igraph.org/c/#docs) page

I think the tests aren't passing because my current implementation only works for simple undirected graphs but directed graphs are being run through the function as well. If I change...