Rasmus Schultz
Rasmus Schultz
Wow. This just works?! With one line of code?! 😂 https://codesandbox.io/s/jsx-with-dot-dom-jjdzy Props, state, state-updates, updates to a parent component, everything just works. That's CRAZY cool. I think maybe now you...
Apparently, yep. (I don't recall why I thought a function was necessary before...)
Okay, so I recall now, #31 for one is something I wanted to address - as well as support for other literals like `true` and `false`. So I would maybe...
Regarding this bit... https://github.com/wavesoft/dot-dom/blob/ddd6d50f9609b97f79ee9af10387598cfa19e7a5/src/dotdom.js#L235-L241 First of all, if this expression is running, don't we already know that the key *didn't* match, and thus the DOM node *must* be new? Secondly,...
Oh man, unpacking this code is *really* tricky... I wish like hell there was a tool that would automate these spooky compression patterns so no one would need to write...
Oh, one thought about keyed updates: I noticed you use the user-supplied key and then fall back to a generated key, e.g.: key = userKey || " " + elementType...
Any reason this got stranded here? I think the only issue was the element-type missing from the key? Other than that, it looks good to go?
For the record, we're talking about [these lines here](https://github.com/wavesoft/dot-dom/blob/7462798dbc46b27e49fd763d5283cc63e0f6352a/src/dotdom.js#L237-L238), right? I'm wondering, can we simply reverse the test and the condition? So instead of `vnode.replace`, how about e.g. `!!vnode.a`? This...
I think we can close this?
...although it's still on a [devel](https://github.com/wavesoft/dot-dom/blob/devel/0.4.0/src/__tests__/dotdom-test.js) branch that might should be merged back to master?