Rasmus Schultz

Results 535 comments of Rasmus Schultz

This would be a breaking change. Going by the implementation, I think the `buffer` type reported by this library intentionally designates the [NodeJS `Buffer` type](https://nodejs.org/api/buffer.html). Although the comment is confusing:...

Unless there's a good explanation for it, I would also suggest that the mentioned comment be removed.

On that same note, I think a mistake was made here: https://github.com/jonschlinkert/kind-of/blob/abab085d65f7ee978011da8f135291892fcd97db/index.js#L12-L14 This has all the same problems I described above - if someone doesn't know this implementation detail, and...

This feature is a breaking change, as previously covered in [this rejected PR](https://github.com/jonschlinkert/kind-of/pull/24#issuecomment-440103074). If some client uses a check like `kindOf(val) === "function"`, this change would break that. The other...

I hope you don't mind my asking, but what is this for? I mean, what's the use of getting a specific, well-known `const string` type like `"symbol"` or `"buffer"`? Because...

@alii I think you misunderstood me - I've used constant string types, narrowing, and discriminators. I wasn't looking for a general explanation of the language feature. I'm wondering when or...

> Ahh please accept my apology for the misunderstanding. I can't seem to really think of a direct use case in this context, but at the very least it's nice...

So uhm. Two years later. Is this still happening? We'll have [PSR-15](https://github.com/php-fig/fig-standards/tree/master/proposed/http-middleware) soon, and at that point, things will really start to take off - in fact, they kind of...

> The Facebook provider tries to use a ubiquitous language between the provider and the Facebook platform Good point. Who calls it a "resource owner" anyway? That's extremely abstract -...

> We won't be changing the name of this in the base package Not what I'm suggesting :-)