Michał Woźniak
Michał Woźniak
nit, please say "KEP for https://github.com/kubernetes-sigs/kueue/issues/1618" in the PR description instead of "Fixes". Otherwise the robot will close the issue after merging the PR :)
/remove-kind api-change the kep by itself does not change api
/lgtm /approve I believe all remarks are addressed, thank you
/lgtm /approve Thanks!
I'm still hesitant (no strong opinion at this point) that this path-mapping approach is simpler than https://github.com/kubernetes-sigs/kueue/pull/3186. It is certainly simpler on the surface, but the path mapping code makes...
I think the extra in-memory pass is only a minimal con. The whole object is anyway serialized / deserialized multiple times during webhook admission and transferred over the wire between...
> Con: More maintenance on our side That is some con, but ideally we can transfer the solution to controller-runtime in the long run. In order to make the transfer...
> Maybe I'm missing something but an alternative (slightly hacky) can be to overwrite the Raw object before the actual defaulter is called. I'm not sure about that, maybe @alculquicondor...
cc @mbobrovskyi @mszadkow ptal, bumping the need for a more maintainable way of synchronizing the manifests as it becomes an issue raised in https://github.com/kubernetes-sigs/kueue/pull/3852.