Michał Woźniak
Michał Woźniak
@Atharva-Shinde @alculquicondor there is one more PR that should be included before the code freeze: https://github.com/kubernetes/kubernetes/pull/111475
@Atharva-Shinde the enhancement is targeting **Beta** for 1.26. This is the KEP update which is currently under review: https://github.com/kubernetes/enhancements/pull/3463.
> LGTM from my side, but I'm not an approver :) Thanks, squashed changes. You may also tag it with lgtm :)
/assign @johnbelamaric
Squashed after the small changes. @johnbelamaric PTAL.
> /approve Thank you, although it seems the approval isn't picked by the automation (after 10min), wondering maybe this is the same issue as @soltysh mentioned: https://github.com/kubernetes/enhancements/pull/3463#issuecomment-1267254343
Initial investigation, after adding a generic error message suggests this is a permissions issue: I0916 16:04:35.577007 1 timed_workers.go:62] "Timed worker function failed. " err="pods \"job-longrun-c7jcp\" is forbidden: User \"system:serviceaccount:kube-system:node-controller\" cannot...
I checked that the existing e2e test "evicts pods from tainted nodes" in `test/e2e/node/taints.go` fails on master when the feature gate is enabled (for testing purposes enabled by modifying `/etc/kubernetes/manifests/kube-controller-manager.yaml`)....