Michał Woźniak
Michał Woźniak
@mszadkow the prototype is great, but please separate the implementation into a dedicated PR, so that we can focus on design first.
LGTM. I 'm not tagging yet to give @tenzen-y a chance for more comments, and think more about [spec vs status](https://github.com/kubernetes-sigs/kueue/pull/5410#discussion_r2172575662) thread.
/lgtm /assign @tenzen-y for an extra pair of eyes
@vladikkuzn @mszadkow please address the remaining comment: https://github.com/kubernetes-sigs/kueue/pull/5410#discussion_r2193331651
/lgtm /approve Leaving final approval to @tenzen-y /hold
LGTM, leaving final tagging to @tenzen-y
/retitle Support Elastic Jobs via WorkloadSlices Just to align with the recent naming in the KEP.
Thank you @ichekrygin Im pretty confident about the PR as for alpha. Going forward I have a couple of thoughts we may tackle in future iterations, or even the first...
I looked at https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/5510/pull-kueue-test-integration-baseline-main/1946075894124646400 at it seems like an urelated flake. Note that the integration test does not enable the new feature gate. Let me retry, if confirmed, I will...