David Wong

Results 393 comments of David Wong

let's implement this directly in the `compute_val` match statement and create a `Value::Poseidon`. Or we could also deprecate it for now (as poseidon could be implemented differently depending on the...

related to https://github.com/zksecurity/noname/issues/38 btw

problem is the wasm part a few lines below ^

I was thinking, if you remove anything that's not in the scope of this PR, and it contains only easy fixes to clippy, then we can merge it in :...

I thought the must_use were false positives? they don't seem correct

sry for reviving this ^^ just pointed out more places that I think we should not fix for now

hey sorry but let's pun on this for now, as I think there were too many potentially dangerous changes :o

thanks so much! a simple change but I've been waiting for this for a long time haha. Do you think you could take a look at the r1cs backend as...

do you know what is happening here? `add_public_output` should not use the double generic gate optimization, maybe it does?

see https://github.com/rust-lang/mdBook/issues/1764