noname icon indicating copy to clipboard operation
noname copied to clipboard

wrong gate for public output in double generic mode

Open katat opened this issue 1 year ago • 2 comments

Currently the public output needs to be calculated at the end and assign to the first column of the witness rows. Each row represents a gate.

When it is single generic gate mode, the output assignment can be done properly in a row (gate) that is reserved for only that public output.

But in double generic gate mode, the gate contains the output wire fails to pass the constraint check.

katat avatar May 03 '24 02:05 katat

do you know what is happening here? add_public_output should not use the double generic gate optimization, maybe it does?

mimoo avatar May 03 '24 14:05 mimoo

oh yeah, it uses add_generic_gate. That is probably the cause.

katat avatar May 03 '24 23:05 katat