Mime Čuvalo

Results 184 comments of Mime Čuvalo

I think this makes sense in general! My only high-level feedback is that it's maybe the case where we don't _always_ want a `WeakMap` but maybe sometimes want a `Map`....

@steveruizok i'm closing this one - it's superseded by https://github.com/tldraw/tldraw/pull/3779 i'll pull over your re-ordering commit to the other PR

It's only an issue if there's one item in the overflow menu (and that's been resolved in this PR: https://github.com/tldraw/tldraw/pull/3779) The popout menu is meant to be stable and not...

discussed some things offline with @steveruizok. i'm pushing this out to staging so i can test out the app properly! @steveruizok and yeah, like i said offline, it's less about...

Great feedback, you two! > At first my "no new APIs for one-offs" alarm was ringing, but the more I thought about this PR, it's really about creating an API...

superseded by https://github.com/tldraw/tldraw/pull/3827 thx folks!

should we send a patch upstream @SomeHats ? or is this very particular to the way we do things?

> It looks like there's been some discussion about the right approach to this on their repo. thx for looking into it!

ugh, our SPA routes were wrong actually (so this was working on other paths but not on the / base path!). the SPA routes are generated from the mapping in...

I'll chime in hear to say that this feels like a much more natural way than the previous iterations. Great progress :) I hadn't thought of this until @steveruizok mentioned...