Milton Mazzarri

Results 25 comments of Milton Mazzarri

> I'm afraid this is a backward incompatible change. This whole bugfix could break the behaviour of existing applications ☹️ 💯 It is backward incompatible. After reading #635, I incorrectly...

> The only part I'm unsure of is whether we should support modifying `executing`, `completed`, etc. Me too, but I think the new approach should solve this. Let's go by...

Ok, no problem. I will try to work on it this weekend o/

> I have added this special case for the ex_doc PR and now I am afraid I need more context when rendering blockquotes and headlines inside code blocks. What kind...

> I disagree. Imagine someone wants to use morphic.js after this has been splitted. You need a > <script> element for every morph. That's confusing for most users. It's not...

As @cycomachead mentioned before: > jQuery is not developed as a single file, but as dozens (hundreds even?) of smaller files. jQuery uses the _Asynchronous Module Definition_ (AMD) API to...

@eksperimental Could you please update this issue with the things that are still pending to fix?

@josevalim Yes, the Swift EPUB use these three CSS files from the Sphinx team (BSD license): * [epub.css_t](https://github.com/sphinx-doc/sphinx/blob/master/sphinx/themes/epub/static/epub.css_t) * [basic.css_t](https://github.com/sphinx-doc/sphinx/blob/master/sphinx/themes/basic/static/basic.css_t) * `pygments.css`

@gonzofish The error I was getting at the beginning was the same as this [one](https://github.com/gonzofish/angular-librarian/issues/78#issue-271844575), even after pointing `angular-librarian` to `git+https://github.com/gonzofish/angular-librarian.git` in my `package.json` and doing `ngl up`. So, I...

@sorentwo I think this is ready for a second review; please let me know what you think.