Joshua S. Miller

Results 8 comments of Joshua S. Miller

@mhenrixon gotcha, that makes sense. We're definitely not setting `nil`, but I've got no idea if other people want that. The fact that `nil` is unexpectedly non-blocking suggests it's not...

@mhenrixon First off, thanks for the awesome gem! We were seeing this issue in production after upgrading and had to revert back to our much older version once we started...

@mhenrixon the README says `lock_timeout: nil # lock indefinitely`, but https://github.com/mhenrixon/sidekiq-unique-jobs/blob/620fe7503f1d0395cad337d2e45681504913c7ef/lib/sidekiq_unique_jobs/locksmith.rb#L273-L277 executes a non blocking call if `config.timeout` is `nil`. Are these two things contradictory? ### edit 1 it looks...

Perhaps a first pass at this can be to allow programmers to throw exceptions which cancel the whole execution? The [executor (L195)](https://github.com/graphql-python/graphql-core/blob/450620de817480e5f36b64b7eb055a2be12abea0/graphql/core/execution/executor.py#L195) seems to swallow _all_ exceptions. I noticed this...

Thanks for reporting, I have been able to reproduce the issue and investigate a solution.

Hi all! Is this something worth considering including in `main`?

Thanks for reporting! Given https://github.com/millerjs/modelm/issues/10 I'm assuming you're on linux? Which distro are you running?

@qria, you bet I did. will upload, thanks!