Gary Miller

Results 21 comments of Gary Miller

Pls ignore my previous comment. On Thursday, 18 January 2018, Daniel Nephin wrote: > *@dnephin* commented on this pull request. > ------------------------------ > > In command.go > : > >...

@KvanTTT I personally think that it is totally appropriate to asking this type of performance issue question here. This does not look the type of question that could be answered...

@sharwell (cc: @parrt, @pboyer ), Sam, I really need to pay more attention to your comments. Your comment above only made sense to me this morning. That was after spending...

@pboyer Just saw your message. I don't have time right now so actually haven't test this. It should work as it is the changes I made to the generated code....

@wdscxsj can you please provide some more details. - What version of Antlr? - How did you generate the profiles (eg. benchmark, one off run, etc.)? - Is you testing...

@wdscxsj a couple of things to note. - Since the parse is only run once, the assumption is the use-case is some sort of code analysis and not a long...

@wdscxsj if Go is 2-3x slower on a single run then my guess would be that is would be even slower on a benchmark because of the JIT. I agree,...

@pavelvelikhov take a look at the last comment in #1540. I would be interested to know if it's a similar issue.

Thanks, ok now I get filter.Skip(). You have a preference for functions where I was probably expecting an interface, and therefore found it a bit difficult to parse the api....

Is there an example project that works now?