milhauzindahauz

Results 22 comments of milhauzindahauz

@nvie Added unnecessary white space. Can be deleted.

Yes, will do that in the evening. On Tue, Sep 13, 2022, 16:37 Fabio Caccamo ***@***.***> wrote: > ***@***.**** requested changes on this pull request. > > Could you provide...

I am going through methods of benedict class. I am trying to figure out all the methods for tests.

Feel free to check it and let me know what you want to do with it. Cause there is TypeError if I remember it correctly. On Wed, Sep 14, 2022,...

@fabiocaccamo, if you want to cover this more thoroughly by test, can you help me and compile the list of methods you want to cover? Thanks

> Another important thing to test: What happens if the `benedict` object is created with an initial `dict` that contains some keys that are `*`? > > Thank you again...

> I would say that we are ready for merging this PR, is there still something missing or that you would like to fix? I build some tests for methods...

Ciao @fabiocaccamo I do, I can make other PR for that later. But there is issue which needs to be solved. List access with index is chain-able but it is...

check it out in 9e136ea6b91d11b2d7eb44556a0337c65201c409. It's implemented.I added test as well. But I am not sure, this is correct behavior.

@fabiocaccamo I got it working. But there is a new side effect. I am not sure I should mark it as [a bug or a feature](https://github.com/milhauzindahauz/python-benedict/blob/bda6ceba55fa4937f82794b3333c2735c4ec5a0e/tests/dicts/keypath/test_keypath_dict_list_wildcard.py#L54)