R. Miles McCain
R. Miles McCain
This will make theming much easier by providing simple primitives for these groups of elements.
``` warning: unused `std::result::Result` which must be used --> target/package/armorlib-0.2.3/src/binary_object.rs:31:9 | 31 | file.read_to_end(&mut data_vec); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: #[warn(unused_must_use)] on by default ``` https://github.com/milesmcc/ArmorLib/blob/f2e370433b5ea4e8d84ffabcd72e00c8881d0dbc/src/binary_object.rs#L31
Create https://armorlib.org/docs/lib/GETTING_STARTED.html
As of right now, I'm not sure how to best deal with `File`s during testing. There is code that uses the `File` type that needs to be tested. Help wanted!...
**Expected behavior:** The scan module `unicode_fingerprint` is called `unicode_watermark` (from _watermarking_). Furthermore, the unit struct should be called `UnicodeWatermarkScanModule`. **Observed behavior:** It's called currently `unicode_fingerprint`, which means something [different](https://en.wikipedia.org/wiki/Fingerprint_(computing))
**Expected behavior:** string scan module has tests **Observed behavior:** string scan module does not have tests https://github.com/milesmcc/ArmorLib/blob/c6e83242113ae3c861e50d7c19fdcc870e91eb02/src/scan_modules/strings.rs#L63
**Expected behavior:** Utf32 extraction (in `preprocessors::text`) has a test **Observed behavior:** Utf32 extraction (in `preprocessors::text`) does not have a test a test **Environment:** n/a **Screenshots or stacktraces:** (insert below) **Other...
**Expected behavior:** `HexPreprocessor` has tests **Observed behavior:** `HexPreprocessor` does not have tests **Screenshots or stacktraces:** (insert below) https://github.com/milesmcc/ArmorLib/blob/c6e83242113ae3c861e50d7c19fdcc870e91eb02/src/preprocessors/hex.rs#L1-L29
**Expected behavior:** `preprocessors::filetype::do_bytes_match()` is fast **Observed behavior:** It's not fast; see the `// TODO: optimize`'s on L75 and L80: https://github.com/milesmcc/ArmorLib/blob/c6e83242113ae3c861e50d7c19fdcc870e91eb02/src/preprocessors/filetype.rs#L66-L85
**Expected behavior:** preprocessor has more filetypes **Observed behavior:** preprocessor only has a few filetypes **Environment:** n/a **Screenshots or stacktraces:** (insert below) We currently have the following filetypes detected ([magic number](https://en.wikipedia.org/wiki/Magic_number_(programming))...