Miles Johnson

Results 568 comments of Miles Johnson
trafficstars

This should fix the emoticons: https://github.com/milesj/emojibase/commit/a39d1a83946d2420342a54165383e252966510dd (I'll release it later) Need more info for the thumbs up.

Actually, I found the root problem. So heres the source data for `2639`. The issue is that the default presentation `type` is text (`0`) instead of emoji (`1`), and that's...

Ok, I'm gonna do a retro breaking change on v5, so compact will always use emojis: https://github.com/milesj/emojibase/commit/14d8b9794d88dbfa1e765d1bf6e677654172e540#diff-8128864d03457e2abb445b92204a88feL25 When you update to v5, let me know if this is still an...

Hrmm, really can't help more unless I know which emoji hexcode is being rendered, and how, and what the actual dataset for that item looks like.

@slugalisk Thanks for digging into this, I haven't had much time. Since this seems to affect `compact`, does non-compact work fine?

@roderickhsiao So emojibase only supports locales that have been requested by the community. Felt like overkill to support all of them from the beginning.

@rahujoshi Interweave was only designed for HTML as it parses it with the DOM, SVG wont work. I'm not sure why you would run SVGs through interweave anyways.

It depends on whether [`createHTMLDocument`](https://developer.mozilla.org/en-US/docs/Web/API/DOMImplementation/createHTMLDocument) supports parsing SVG correctly or not, which is what Interweave uses under the hood. I can't recall off the top of my head.

Awesome transformer. This may be a quick win to support it in core in the future.