Miles Frain

Results 96 comments of Miles Frain

Looks good in general. Just a few comments. Regarding adding a section on rendering to browser, perhaps let that be a separate PR, since that may involve some additional discussion...

Complimentary issue in the book: https://github.com/purescript-contrib/purescript-book/issues/238

> Clone from where? From the same location that `spago install` would clone/copy from. > And eventually, it also should bring back changes it made? Are you referring to upstreaming...

> after Miles' maybe has also weighed in? Diving into this is on my backlog. Hopefully will be able to offer more meaningful review feedback in a week or so....

That might be enough. Looks like we'll have to wait for the package set to incorporate `runWidgetInSelector` and then wait for TPS to incorporate the updated package set.

Leaning against this because: * The guide notes that warnings will appear. Maybe this point in the text just needs some emphasis. * These compiler warnings are fairly human-friendly. *...

Pinging @danielstaleiny for input, who initially set this up in #144

I suspect that any Windows environment that has `make` (e.g. WSL) is also likely to have `bash`.

> this is probably what you were seeing in the book Yep, looks like the same issue. Some code snippets here: https://github.com/purescript/purescript-st/issues/33

The Euler example is still a nice demo, but could send users down some rabbit holes if they don't have a FP background. Maybe Euler could be featured as an...