purescript-cookbook icon indicating copy to clipboard operation
purescript-cookbook copied to clipboard

Fix Concur recipes in TPS

Open milesfrain opened this issue 5 years ago • 2 comments

We're using div id="app" in index.html, but TPS doesn't have access to this file, so runWidgetInDom "app" can't find what it needs.

try

We probably need to use a similar launch strategy as the Halogen and React recipes (see #198)

Also might be good for Concur to log an error to the console if runWidgetInDom can't find the element.

@gcsolaroli and @ajnsit for suggestions

milesfrain avatar Aug 08 '20 22:08 milesfrain

Concur has runWidgetInSelector as well which can populate the widget directly in the body i.e. runWidgetInSelector "body". Is that enough?

ajnsit avatar Aug 08 '20 22:08 ajnsit

That might be enough. Looks like we'll have to wait for the package set to incorporate runWidgetInSelector and then wait for TPS to incorporate the updated package set.

milesfrain avatar Aug 08 '20 22:08 milesfrain