MILAN CHAHAR
MILAN CHAHAR
Hi @fisker, I've added the missing changelog entry and updated the checklist. The PR is fully complete now. Could you please review and merge this? Thanks!
Sorry SIr about the mistakes in the changelog—I missed the filename and author link requirements. I am still learning the contribution workflow. Thank you for fixing it and adding the...
Fixed! I have renamed the changelog file to `18414.md` and corrected the author link format as requested.
I am sincerely sorry for the confusion. I realized that while trying to rename the file earlier, I accidentally overwrote the fixes you had made. It was not intentional. As...
@43081j Thanks for the review! I have updated the PR with the requested changes: 1. Reverted `package-lock.json` to discard unintended changes. 2. Removed the separate test file and moved the...
@43081j I apologize for the oversight! You are absolutely right—I missed pushing the logic updates in the previous commit. I have now verified and pushed the correct changes. The `assertions.js`...
@43081j Sir please check.
@43081j Thanks for catching that! I've reverted the accidental formatting changes, so the diff is clean now. I also updated the code comments as suggested to explain the logic better....
@43081j , Sorry for early mistakes. I am new to open source and I have made changes according to the requirements please review it. Thank you for your feedbacks.
please check