mikupls

Results 39 comments of mikupls
trafficstars

Added another commit to support "new.reddit.com"; discovered on `r/japan/comments/skbmu8/the_rjapan_basic_questions_thread_february_2022/`.

Hey, I wonder if #489 would be close enough for your use-case? It's not very end-user-friendly, but at least you'd be able to define/drop-in your own theme a bit more...

Yeah, you're right :) It is more geared towards developers/people that self-host, but don't want to edit the source code for adding new themes. So the idea to have a...

Ah true, IIRC for some reason I thought that the function is only applied to URLs (maybe because of the naming `rewrite_urls`), but a quick search shows that the entry...

Comparing the problem case from #281: https://www.reddit.com/r/NatureIsFuckingLit/comments/pfywdx/isistius_brasiliensis_cookiecutter_shark_mouth/hb7tusx.json with our new problem case: https://www.reddit.com/r/ProtonVPN/comments/qaxigk/opensuse_unofficial_guide_on_how_to_install/hl1iw6g.json It seems like maybe we can get away with *only* filtering the url-encoded backslashes.

Happy new year :wave: I'm back after a long vacation :) Great to see all the improvements to libreddit in the meantime. --- The change in this PR might seem...

I was just catching up on new issues, and this PR also seems to fix #389 (by removing the SVG tags).

Thank you both for the explanations! So what is the proposal or solution here? Only display these images in-line when inside the post? (I would prefer also having the previews,...

Hi :wave: I just rebased on master and added my old fix for backslash rewriting. I've been using both commits personally for some months now and did not encounter any...