Miguel San Segundo
Miguel San Segundo
This PR is working very well. Would love to see it merged and released👍
+1 for adding margin controls on template part blocks too because that would allow us to reset the global block gap as suggested in the issue https://github.com/WordPress/gutenberg/issues/47637. See how the...
We did these improvements: - D90635-code - D91400-code
Sharing testing notes: ## Atomic sites ### The subscribers screen mainly works 🐛 There is a bug when there aren't any subscribers because the Launchpad component is not working on...
I have added some changes to this PR: - [x] Fixed the migration feature using `calypso/lib/wp` for the request so the user gets authenticated. - Tested on Calypso green and...
> could you check whether the problematic back end Atomic site is running a custom/dev version of wpcomsh? @daledupreez, that was it. That site is a testing site that was...
There are still issues only on Calypso green because the requests made from Launchpad are not authenticated. The error is a 401 `rest_forbidden`. Launchpad requests work when we use `wpcom.req`...
The commit https://github.com/Automattic/wp-calypso/pull/87684/commits/c12495d62f4eece013a368472bbcab4289b4848c is another example of how we can fix the request authentication issue. It fixes the issue with the emails not being sent when a subscriber is imported...
> JN sites Launchpad behaves differently than the Atomic ones. The correct design is the one from Atomic, including the actions. We shouldn't open Support Pages here, users will end...
>JN opens [support pages](https://wordpress.com/support/import-subscribers-to-a-newsletter/), Atomic doesn't work. It should open the site editor, with the Subscribe block: /site-editor/jetpackgoku.wpcomstaging.com?canvas=edit&help-center=subscribe-block The task "Add the subscribe block to your site" opens the editor...