wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard

Published 20 hours ago • verified publisher icon Automattic

Pattern Assembler: Improve performance of pattern/site preview endpoints

Open miksansegundo opened this issue 2 years ago • 2 comments

Can we optimize existing endpoints block-previews/pattern and block-previews/site for the PA project? The reason is that PA does not require:

  • to verticalize patterns or sites
  • to add styles or scripts based on the theme (always use Blank canvas)
  • to generate HTML with content for a source based on the theme (always is dotcompatterns)

Other optimizations

  • The HTML of each pattern is always the same so that the response can be pre-cached.
  • Any other possible improvements?

Related #67076

miksansegundo avatar Aug 29 '22 07:08 miksansegundo

@Automattic/ganon This is how @fushar :)

autumnfjeld avatar Sep 06 '22 07:09 autumnfjeld

Now that I just played around with the feature, I (subjectively) feel that the current performance is good enough. I suggest before taking any action on this issue, let's wait for the CfT and see if people will find that the feature is slow.

fushar avatar Sep 20 '22 02:09 fushar

@miksansegundo can we close or conclude this issue now? 😄 I think we should link to the past PRs / diffs that contribute to this endpoint's performance improvements.

fushar avatar Nov 28 '22 06:11 fushar

We did these improvements:

  • D90635-code
  • D91400-code

miksansegundo avatar Nov 28 '22 07:11 miksansegundo