Mikko Karjalainen

Results 16 comments of Mikko Karjalainen

There is a `it("Logs an SSL handshake exception")` test in `TlsErrorSpec.scala` to give you some ideas @VivianLopes .

Revisit this issue after Netty upgrade: PR #484.

> Please clarify and document the Netty behaviour - and close this issue if no work is required. Check above. I have edited the description.

Accidentally closed. Reopening.

Test case to demonstrate this issue: ``` test("Routes to new origin when the origin indicated by sticky session cookie is no longer available.") { server1.stop() val client: StyxHttpClient = newHttpClientBuilder(...

As a short summary, Styx `Url.Builder` uses `java.net.URI` to parse URLs to their subcomponents (scheme, path, query, etc). It is the `URI.create()` method that rejects URLs with double percentages (`%%`)....

My impression is that the spec (chapter 2.4) prohibits double percentages (`%%`) unless encoded to `%25%25`. In this regard Styx behaviour is correct, although I understand your requirement for allowing...

Hi @yashvyas > Styx doesn't check whether URL is encoded or not before attempting the unwise char encoding right? Browsers and other clients must send URLs in percent-encoded form. Otherwise...

One option is to implement a pair of `release` methods: static Function release( Function usersMapper) { return input -> { ByteBuf output= usersMapper.apply(input); if (output != input) { input.release(); }...