Michael Solomon

Results 164 comments of Michael Solomon

I'm closing this. Feel free to reopen it if needed.

I was unable to merge the master to this PR to resolve the conflict, so I will wait for the contributor to do it. If not, I will open a...

I don't think this is a bug. There is no "good" or "bad" behavior here. [It's like the question](https://stackoverflow.com/questions/6439416/status-code-when-deleting-a-resource-using-http-delete-for-the-second-time) of whether an HTTP DELETE endpoint should return 204 or 404...

@mkurapov Does this happen to you in 13.5.1? https://github.com/nock/nock/releases/tag/v13.5.1 @VladimirChuprazov fixed a memory leak.

Maybe related to: https://github.com/jestjs/jest/issues/6814

@mbargiel It looks good in general. I'm a bit concerned about the behavior changes in the [remove persisted interceptor](https://github.com/nock/nock/pull/2355/files#diff-4fd1b72cbc9494d987be2c86c3de848f8612f6d94b0f02703ec5425ddde7e8c4L90), which may break some users. I am wondering if we need...

I see your point. 1. I'm wondering why these methods are not documented. 2. Why do we need `scope.remove` at all if we have `nock.removeInterceptor`. Is there a chance `scope.remove/add`...

@gr2m If we decide to remove them. i suggest deprecate them for 14 and remove in 15.