Mikhail Maslo

Results 22 comments of Mikhail Maslo

Did it work for you @Blackjacx? Cause I tried to build it and got same errors as without this PR changes (and CI check indicates the same errors)

Hi Ruslan, Thank you for your suggestion, I have several concerns and want to share them with you: 1. First of all, is this behaviour still happens on iOS 15...

I've used the same approach with resetting frame in `viewDidAppear` in subclassed `UIHostViewController` and it worked in simulator on iOS 14 and 15. No glitches or anything bad with UI....

Great! Thank you for taking your time to verify this workaround, then I'm closing the PR 👍

Oh, I see. I though that you've tested the proposed fix above with subclassing. Then I'll reopen the PR. As for testing radar's workaround, besides iOS 14 and iOS 15,...

If you don't mind, I'd make several changes then in suggested workaround: - iOS version check - we don't need it for iOS 12 and iOS 13 - View controller...

(not insisting on it) In addition, maybe it's worth considering something like this, if it's enough for UIKit / SwiftUI to recalculate the frames ```Swift let sourceViewFrame = sourceView.frame sourceView.frame...

Additionally, it's quite complicated to check if a view controller is `UIHostingController` since it has generic `Content` So, I suggest to make version check (iOS 14+) and do this workaround...

Hey @Rusik, did you have a chance to finish discussed fix?

@Rusik Done ✅ https://github.com/joomcode/BottomSheet/releases/tag/2.0.1