mikewrighton
mikewrighton
I guess I was thinking that since there is some useful code around the schema loading, like in `zipkin.storage.cassandra.Schema`, it might be good if it were somehow extensible e.g. if...
FWIW I also have a use case for the 'decoration' of existing spans. I'm trying to add log fields from a Log4j-based logging system, but the log appender runs asynchronously...
> You are trying to implement a log appender which adds logs to the active span? Interesting! Have you tried using a non-async logger for that? Yep - 'active' as...
@felixbarny Yeah it's a good point - I wasn't sure how much log processing would be in the critical path e.g. variable processing, but I think it looks fine, so...
@kornicameister is it possible to create a repo with a project that reproduces this error? I wasn't immediately able to reproduce with the code in the original description. Thanks!
Am I right in thinking that flags are only used by logic in the instrumentation code, not anywhere in the Zipkin backend?
I took a look at [apigw-http-api-lambda-dynamodb-python-cdk](https://github.com/aws-samples/aws-cdk-examples/tree/main/python/apigw-http-api-lambda-dynamodb-python-cdk) and was able to root cause at least one issue causing these type checker errors. When you implement an interface in TS, the method...
Seems like there's a way to avoid the tree.json being generated, with: ``` const app = new cdk.App({ treeMetadata: false }); ``` Is this a reasonable workaround for you?