Mike Samuel

Results 183 comments of Mike Samuel
trafficstars

@ljharb, If you think we'd remember to reopen should dynamic-code-brand-checks founder.

It looks like tests pass for node >= 6 and fail for node < 6. This is because of ES6 language features used. Working around those to be ES3.1-compatible shouldn't...

Ok. So to move this forward, I could move Template.js and its tests into a separate npm module. Could that live under the `github.com/mysqljs` org? On failing gracefully on older...

> Why not into the sqlstring module? Sorry, didn't read closely enough. Will do.

@dougwilson I filed https://github.com/mysqljs/sqlstring/pull/29 there. If you want to close this, I can see what happens there and then come up with a new PR here, or if you want...

So we would use the `this` value as the constructor? Would it be preferable to invoke the constructor assuming it takes (source, flags) or to try to do something Object.create...

Pull request: https://github.com/mikesamuel/regexp-make-js/pull/18

How much of of get-originals can't be done in early running user code?

There are probably legitimate use cases for interpolating capturing groups. Strawman 1: - Export another property, templateGroups which is an Array such that for each group number i in the...

Fixed at https://github.com/mikesamuel/regexp-make-js/commit/2e3d0ae63b7707a3f83f209cd359955fa504c5ba