Mike Samuel

Results 183 comments of Mike Samuel

The test failures seem to be related to `npm run-script` of `eslint` and `test-ci`. I'll tackle that in the next commit but probably won't push anything until tomorrow.

The remaining Travis CI failures seem to be in test-{Lexer,Template} because the following test is not working on Node runtimes with version 0.x.x: ```js var nodeVersion = process.env.npm_config_node_version; if (/^[0-5][.]/.test(nodeVersion...

I discovered `npx` which lets me test with various versions. ```sh $ npm install --no-save npx $ ./node_modules/.bin/npx [email protected] test/run.js 1..3 ok 1 test/unit/test-Lexer.js Skipping ES6 tests for node_version v0.12.18...

Tests run green now. I've looked over the coverage report. The main sticky point there is ``` // lib/Template.js try { module.exports = require('./es6/Template'); } catch (ignored) { // ES6...

> The coverage is definitely a union as reported to the PR status Ah. I see https://coveralls.io/builds/15290075/source?filename=lib%2FTemplate.js Nice!

> it's lines not covered in any Node.js version run. It was unreachable since the lexer patterns will all fall back to matching the empty string. Fixed.

> No, it was as I said at the time I made comments. I'm not sure why you are assuming I'm making comments on changes you made after I made...

> Very sorry, I guess I just misunderstood what you're trying to say 😂 So what are you trying to say? I saw your comment just after I'd convinced myself...

> Also something to think about would be if you'd be open to committing to helping maintain this stuff for the next 1 year or not. I'm planning on doing...

Docs at https://github.com/mikesamuel/sqlstring/tree/contextual-template-tags#es6-template-tag-support