Michael McCandless

Results 210 comments of Michael McCandless

> I tried benchmarking this with luceneutil, but did not see any significant change with the default benchmark - I suspect that I'm using the wrong luceneutil tasks to see...

> Do we believe that we can merge this PR and then continue with changing the BKD visit API in a later change, or should we try to change the...

> * Add a new test case which calls `doTestRandomLongs` with 20 000 - without this I couldn't get the IntsRef to trigger often enough. This should maybe be a...

> > * Add a new test case which calls `doTestRandomLongs` with 20 000 - without this I couldn't get the IntsRef to trigger often enough. This should maybe be...

Thanks @antonha -- sorry, maybe also add a `CHANGES.txt` entry? This is an exciting opto!

OK I merged a backported to 9.11.0 -- I think that's safe: we added a new default method to `IntersectVisitor`.

> Perhaps if we index Month and Year as docs-only fields we would see some impact on queries with those as filters? +1 -- did that show any measurable performance...

Hmm it looks like this change was nearly ready to be merged? But code has since drifted and the PR now has some rust (conflicts)?

> I'm not sure why FSTPostingsFormat is different from the rest, that it write both the metadata and data to the same file. I think writing to separate files would...