Mickael Meausoone
Mickael Meausoone
I didn't want to make a description too long, but feel like a bit more context could be interesting: As part of contributing to linkedom (https://github.com/WebReflection/linkedom), I was adding event...
Should this be closed? This was approved but now is quite old and I'm not sure if there is any interest in merging it. I solved the conflicts just in...
> No this fix looks correct it was just missed - apologies this is our bad. No worries, thank you for the answer! There seems to be errors on the...
Pull request updated: solved conflicts, rebased, tested (everything passed) and pushed again. Everything should be fine now.
Hey, just a note that previous checks run had 3 failures: `node-test-commit — tests failed` `node-test-linux-ubuntu1804-64 — tests failed` `node-test-pull-request — tests failed` This time those are failing: `Test ASan...
> Ah, CI is green but GitHub CI needs to rerun so let's do that @benjamingr Sorry for the question but is there anything I should / could do? I...
I think I found the issue: my git config when I created the PR at the time pointed to my work email, making the author different from current editor and...
@benjamingr would you mind rerunning the CI for this PR? Thank you for your help 🙏