Mikyo King

Results 236 comments of Mikyo King

Given the release of https://github.com/google/adk-python/releases/tag/v1.0.0 we probably will just go ahead and instrument that. That way his package will be a bit more stable.

> The ADK already includes tracing logic, which is implemented in https://github.com/google/adk-python/blob/main/src/google/adk/telemetry.py > > Usage Example > > https://github.com/google/adk-python/blob/main/src/google/adk/flows/llm_flows/functions.py#L393 > > However, the trace keys are not compatible with the...

Going to try to see if it works on conjunction with: https://github.com/langchain-ai/langchain-mcp-adapters

OTEL context doesn't seem to be able to be attached in a meaningful way: ``` Traceback (most recent call last): File "/Users/mikeldking/anaconda3/envs/langgraph-mcp/lib/python3.13/site-packages/opentelemetry/context/__init__.py", line 155, in detach _RUNTIME_CONTEXT.detach(token) ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^ File "/Users/mikeldking/anaconda3/envs/langgraph-mcp/lib/python3.13/site-packages/opentelemetry/context/contextvars_context.py",...

> So, is this the reason why the spans inside my tools appear outside the chain? > > Man, i was going nuts trying to fix it. I believe so....

> Is it really completed? It's not, it's just fundamentally not possible with the langchain tracer as is since it doesn't create spans through OTEL natively. Happy to keep it...