Michael Gee
Michael Gee
+1 from me, too. Is there anything we can do to help get this merged?
👍 > Having a method to be able to set or get `HTTP.default_headers` as a hash would also be nice. I agree with the sentiment in this request. In my...
https://github.com/httprb/http/wiki/Proxy-Support ?
I've found this gem doesn't handle nested params natively and have resorted to using [ActiveSupport's `#to_query` method](http://api.rubyonrails.org/classes/Hash.html#method-i-to_query) This request: ```ruby HTTP.get('https://requestb.in/qzba87qz', params: {filter: {post: '1,2', author: 12}}) ``` makes this...
👋 apparently this similar solution is more correct: https://github.com/thoughtbot/dotfiles/issues/655#issuecomment-605019271 I don't really understand these things. I just remember seeing this error mentioned in a PR or issue before and found...
Makes perfect sense, but the false positives concern me. I suspect we'd get a bunch of those.
Also consider using `github_pr_review` rather than `github_pr`. That should make all the comments with one HTTP call.
seems legit to me 👍
I agree that the new style should be considered **acceptable**: ```ruby private def quux(foo, bar) foo
Instead of the boolean algebra, the other solution to "unless with multiple conditions" is extracting the conditions to a method.