Mihir Singh

Results 10 comments of Mihir Singh

I'd be interested in giving this one and/or #602 a shot, @nataliayave are you still working on this? I can pick up #602 after if you are, otherwise I can...

Thanks, I've commented on #749

@gavv yes I'll take this one thanks

Hi @veronikaro, go ahead

Hi @gavv thanks for the feedback. Haven't pushed them yet but made some changes that align more with the first approach (calling sem_post N times based on the number of...

Hi @gavv, sorry for not giving an update earlier, might be a little while before I can pick this up again so maybe I can be unassigned for now -...

Sounds good, made these changes in [880cdd7](https://github.com/roc-streaming/roc-toolkit/pull/743/commits/880cdd7ecb4aaaf1e8672448ec2e92d5e41bb59b). Also, do we want EmbeddedCapacity to represent (a), the max queue capacity that we allow for using data embedding (in this case the...

> I guess we should do something like: > > ``` > AlignedStorage embedded_data_; > ``` > > ? Got it, made that change thanks. I think everything should be...