Mihailo Milosevic

Results 10 comments of Mihailo Milosevic

@cloud-fan Could you take a look at this fix?

This is now ready for merge, all tests have passed, as find_in_set was fixed this morning.

@itholic please update description of the PR to follow the changes added.

Hi @panbingkun, thanks for taking initiative to push this work forward. The design of the table was discussed previously and the structure that was agreed upon should take a slightly...

I believe for now we agreed to have only `SHOW COLLATION(S)` as a command, and then add support for both LIKE and ILIKE operators for searching. But it is enough...

Hi @panbingkun this is starting to look like what we want to get as a result. Thanks for taking the initiative. Apart from the SQL command for SHOW COLLATIONS we...

Hi @panbingkun I left some comments for you, sorry for the delay. I believe you are really close to getting to the point of what we want from SHOW COLLATIONS...

Hi, @panbingkun. Sorry for delay in the response. As adding this listing of collation functionality is making other changes necessary, I believe it might be good to keep this PR...

@MaxGekk @HyukjinKwon I added tests and fixed one test in DataFrameSuite, as it was not completely using aggFn parameter