Yuri Sokolov
Yuri Sokolov
Don't think it should be in the issues, because it isn't. You have multiple approaches here. If you just want the code to compile, append the `async` keyword to the...
@softshadedev thanks, I will take a look at it! Probably this scenario isn't covered by unit tests - will add them as well. I also want to see how I...
@softshadedev I've merged the handling of non-id registrations with id registrations and added a unit test to make sure that collections returned as expected no matter how the dependency is...
I'm currently in the process of trying it out in a big scope, mobile project. Once it's live, it is expected to be tested on hundreds of thousands of users....
Well, on my side - it passed all checks I wanted it to pass and the PR is now ready. @hadashiA, I would appreciate a review.
I understand that this is a huge PR and it takes time. Maybe we can start by running the rest of the tests and in case something's wrong I'll fix...
Hey @hadashiA, first of all - huge thanks for the fantastic work you’re doing. I completely understand your reasons for taking the time on this PR. Please, don't hesitate to...
I’m not sure about the name `Keyed` — it doesn’t sound quite right to me. Maybe something like `WithKey` would feel more intuitive? That said, it’s definitely not a deal...
@hadashiA anyway, I've pushed the change both with `KeyAttribute` and `Keyed` method name. Also added the documentation to the website.
Awesome news!!! Thanks!