Shahar "Dawn" Or comments

Results 487 comments of


                                            Shahar "Dawn" Or

Check for equal namespaces in the sameVnode function

I wonder when would this be helpful. When would elements of possibly different namespaces be compared?

Check for equal namespaces in the sameVnode function

Why would there be "two elements with the same selector and key"? Wouldn't that be unsupported?

Check for equal namespaces in the sameVnode function

On second thought two elements having the same selector and key seems common.

Logical error in props module?

Hi, @kay999. Could you write a failing test case and make a pull request out of that?

Document supported browsers

How about [`defaults`](https://browserl.ist/?q=defaults)?

Document supported browsers

I would actually like this to remain open, with a slight change of title, if no-one minds.

`h` should be more strict about children

I changed the title to be more general. I'm not sure whether `h` should be more strict about children only in TypeScript types or at runtime, as well. At runtime...

toVNode naively includes ids and possibly classes in `sel`

https://github.com/snabbdom/snabbdom/blob/a42c31a300b7d689ad8a0b424afac67636da54d7/src/vnode.ts#L13-L20 The VNode interface has only the `sel` property to store the tag, the `id` and the `classList`. The `sel` from your example is `div#parent.child`. A dot in `sel` will...

toVNode naively includes ids and possibly classes in `sel`

Previous comment sent prematurely. Updated.

Patch can't diff the same tagName element?

@kuraga thank you for making sure what happens here is clear. I closed this because there's no proof of a bug and no response from the original poster. Should I...