Shahar "Dawn" Or comments

Results 487 comments of


                                            Shahar "Dawn" Or

feat: detect useless parens in binops

Sorry, I think #138 is the priority so we've been working on that.

feat: detect useless parens in binops

Now that we have #138 would you mind rebasing (again, sorry)?

feat: detect useless parens in binops

> @mightyiam I noticed that there are quite some tests all test on the `manual_inherit` rule instead of the rule the filename indicates, maybe this is a mistake? Yes, sorry....

Goal: successfully parses Nixpkgs

I hope this is solved by #102.

fix: bool comparison

https://github.com/molybdenumsoftware/statix/commit/6d516fb90a65c9cb1fe92e825a63e992bc64b079

fix: we matched too much code on select statements

https://github.com/molybdenumsoftware/statix/pull/56

Goal: "fast enough" (details inside)

On my machine with AMD Ryzen 9 7950X it takes less than 7 seconds with only `empty_let_in` enabled.

feat: allow user to pass multiple files to `fix` and `check` commands

I think we should have this. How about a test though?

feat: allow user to pass multiple files to `fix` and `check` commands

Sorry, I think #138 is the priority so we've been working on that.

feat: allow user to pass multiple files to `fix` and `check` commands

Hey, #138 is complete. Sorry for the conflicts. Looking forward to reviewing this again.