Shahar "Dawn" Or

Results 488 comments of Shahar "Dawn" Or

Thank you for the idea, @christianbundy. I do use 2 statements per line quite often, such as `if (foo) return`. I do not remember when's the last time I have...

While I don't make final calls here, I assume that this would be accepted. Therefore if you'd like to contribute further, I suggest a pull request could be a good...

It's ```js import { a, b, } from 'foo' ``` Each named import or export in its own line. That's a lot of lines, possibly. But I'd pay that happily,...

@staltz sorry, I should have commented on this PR. Here, this is what this is about: https://github.com/cyclejs/cyclejs/issues/744#issuecomment-345654214.

It isn't that I did not understand. It seems suspicious. Not about aesthetics. About consistency of the names in the API. If anyone is using `xs` as type, I'll submit...

> Gotta remember that maybe their project is not be open source. ;) Kind of counting on that probability.

@whitecolor suggestion seems more correct to me, as a novice TypeScript user.

Can't we `return outerSinks as typeof innerSinks`?

Awesome. Keep up the good work. The idea I have is to separate initialization of state from reducing of state. That way a reducer can assume initialized state. It seems...