Kevin Today

Results 27 comments of Kevin Today

> Thank you very much for your great PR! > > I'd like to use allowlist instead of whitelist (related to #BlackLivesMatter). Name `allowed-users` might be better like `allowed-associations`. Switched...

Hey @nwtgck , it actually is disjunctive - a user is allowed to run the script if they have permissions via CommentAuthorAssociation OR allowed-users. It had to be that way...

Hey @nwtgck , I agree that the ideal would be a `restricts` where the user can customize the ACLs with the expression case. I do want to make sure I'm...

Hey @nwtgck , no worries - the `uses: mieubrisse/actions-comment-run@mieubrisse/disjunctive-whitelisted-users` sounds like it'll unblock me. Out of curiosity, is there a downside you're worried about to merging this and then doing...

Was actually just doing some code-diving, and was curious - is the `allowed-associations` check actually needed? This chunk of code already prevents anyone without `admin` and `write` permissions from doing...

Sure: ```go const ( // Key in the Headers hashmap of the token that points to the key ID keyIdTokenHeaderKey = "kid" // Header and footer to attach to base64-encoded...

@dgrijalva super simple clarification that should allow #345 to be closed

I'm not the OP, but @kheraud 's solution fixed this for me. The [example for a custom claims type](https://godoc.org/github.com/dgrijalva/jwt-go#example-ParseWithClaims--CustomClaimsType) has this same logic, so maybe just a quick explanatory comment...

Important note: it's not whether `open *.ipr` or the File > Open menu item from within IntelliJ that causes the Immutables generation issues, but instead what response was given to...

Adding another +1 here; promises would be much, much nicer