Jacob Middag

Results 15 comments of Jacob Middag

> Something's not right here, when I look at the files view, or directly on your branch, it is showing as pkg.Version in the Makefile still, can you double check?...

> UI still showing pkg.Version in the makefile for me, tried different browsers and the GitHub app, perhaps rebase and force push? Done. The UI shows `pkg.version.VERSION`, but the `pkg.version`...

> It has changed now, but shouldn't it be pkg/version.VERSION? No, it should be import path: > -X importpath.name=value > Set the value of the string variable in importpath named...

> The import path _is_ `pkg/version` not `pkg.version` no? Ah yes, you are right. I thought you only meant the package name. I will fix it. Edit: fixed and tested...

@JoelSpeed @tuunit anything needed to get this PR to merged?

How do you mean it isn't a robot account call? I thought the new Robot accounts were also meant to do these kind of calls. We use the workaround, but...