Mick Hansen

Results 67 comments of Mick Hansen

Original one just had the up/down skeleton i believe. It didn't have skeletons for createTable and similar

How did this fail prior to this PR?

Appears to be an issue with Sequelize not passing options to `set` correctly: https://github.com/sequelize/sequelize/blob/master/lib/instance.js#L773 Btw you should only initialize ssaclAttributeRoles ONCE, on individual models OR on sequelize, not on both.

I've opened a PR here: https://github.com/sequelize/sequelize/pull/4138 But you'll have to upgrade to the latest 3.x.x when it's merged.

@gonzobrandon You might want to go ahead and start upgrading to 3.x in any case so you've taken care of all the BC stuff :) I'll hopefully release a new...

The timeout error generated by the library is outside the retry logic loop: https://github.com/mickhansen/retry-as-promised/blob/master/index.js#L66

io.js failing, go ahead and remove it from .travis.yml

I agree, the original default is almost unworkable and hard to implement unless you do so from the beginning.

@hendrul I prefer this behaviour so fine with a major bump. If people want to bypass roles they should define an omnipotent role. Sequelize uses `raw` with `build` internally so...