Michael Bensoussan comments

Repositories
Issues
Comments

Results 3 comments of


                                            Michael Bensoussan

Question: Unit Testing a Decorated Function with max_time

A bit late to the party but for future reference I both tried monkey-patching `sleep` and `timedelta.total_seconds` without success. I finally made it work with a lookup function: ```python def...

Errno::EINVAL: Invalid argument instead of Redis::CannotConnectError

A few of our gems, rescue from `Redis::BaseError` to handle failure (readthis, flipper,...) so with `Errno::EINVAL` in case of failure/failover it fails when it should not. Here's my patch: ```ruby...

Update to handle Google Tag Manager using dataLayer

Hey @penguinstampede thanks for the PR. I'm not very familiar with GTM but according to the documentation the `dataLayer` can eventually [be renamed](https://developers.google.com/tag-manager/devguide#renaming). Ideally I would detect the dataLayer whatever...