Michiel Dethmers

Results 217 comments of Michiel Dethmers

> > In an earlier comment there is an example where one uses `newsletter` and the other uses `lists` Yes, the idea is that in a proxy setup (eg Docker),...

> I have no experience of what you are describing, but if it is required then isn't there an external way to achieve it, using apache rewriting or some other...

Thanks, I've reviewed your suggestions and I think the idea of an adminBaseUrl is good. The main complication is this: 1. publicBaseUrl is set and then used to pre-populate the...

> I think this is fine. Can the website and subscribe page changes wait until another release? The new defines can be explained that they override all other settings such...

Ok, I think I have addressed all the issues, but we may need to do an extensive test if this is in an RC. 1. publicBaseUrl 2. publicConfigBaseUrl -> to...

Hmm the CI fails, but I think that's not the code, but Github playing up

> Hmm the CI fails, but I think that's not the code, but Github playing up I re-started the actions and they pass now

Just a quick explanation on why this is needed. In Docker, or other "proxied" setups, you have one container (eg swag) at the front sending traffic to backend containers. The...

* Pageroot needs to match the value on the backend server, so I've updated that in the explanation of the value. * I've fixed the init.php and sendemaillib.php * the...

Hmm, but it's true, CKeditor doesn't work. It throws this error https://github.com/bramley/phplist-plugin-ckeditor/blob/master/plugins/CKEditorPlugin/kcfinder/core/class/uploader.php#L251