Michiel Dethmers
Michiel Dethmers
Yes, I also noticed that postgres has date_add, but only from version 16. I'd like to try to support 14+ But if the functions are not interchangeable, we'll have to...
Yes, interesting. I guess with the current admin arrangement that's not easy. Maybe for now, each team has a shared login. Maybe we can make the "admin" in the system...
Thanks. It's not really a code change, so I've marked it ready to merge, but if you can [sign the CLA](https://www.phplist.com/cla) anyway, that would help with future contributions.
Great, thanks. Was that with this account? Because I didn't see your handle in the list. It's there now, thanks
I think most of these were already done before. Just the one commit let.
You're right. We should the hostname() here, so that it initialises the website and domain config settings correctly https://github.com/phpList/phplist3/blob/main/public_html/lists/admin/connect.php#L21
Not only that, I'm using the wrong value. I should use HTTP_X_FORWARDED_HOST or HTTP_X_FORWARDED_SERVER HTTP_X_FORWARDED_FOR is the IP address of the user.
Ok. I've decided that "auto detection" and config is too complicated and open to massive errors. Instead I've now introduced "ADMIN_WWWROOT" and "USER_WWWROOT" so that the URLs can be hard...
The CI is failing, I'll find out why
ok, good we have CI. There were some errors, but that's fixed now. I may add some tests with these values set in the config file as well.