Michel Fortin

Results 160 comments of Michel Fortin

It's not just historical. [Other test suites](https://github.com/fletcher/MMD-Test-Suite) are based on MarkdownTest and use ".text" too, so I'd tend to keep it as it is for interoperability reasons. We don't gain...

That indeed serves no purpose, but should be harmless. And it turns out you're not the first to [comment on that](https://github.com/michelf/php-markdown/commit/c51009eaf548a40768b34552ba31c81dab21f139#r4880630). I should have fixed it then. Feel free to...

I think this fell off my radar and I forgot to reply. Sorry. I think your analysis is quite good. Throwing seems like a good idea. I'd suggest we do...

I don't think there is any particular reason it's not supported. Feel free to work on this, it'd be a good addition. I don't think there is any particular reason...

This is related to the no_entities mode. I suppose using the hashing system to make the generated `&` invisible to subsequent passes would fix the issue. For instance by adding...

It's supposed to create a reference to `$this->footnotes_number[$note_id]` so that if you write to `$num` it'd also change the other place. So [this other line](https://github.com/michelf/php-markdown/blob/lib/Michelf/MarkdownExtra.php#L1750) is actually assigning to `$this->footnote_number[$note_id]`,...

I'm not too sure what's the point of adding this test case. Does it test for a an existing bug? And if it's a test case, where is the corresponding...

I don't understand why you'd want to put the same class names on every image. If all the images need the same style applied to them, isn't it already easy...

If I offer this it'll be a setting on the parser, not something within the syntax. I'm seriously considering offering a callback in the API to allow altering emitted link...

> Is there any progress on this issue? Not much. The time can afford to put on PHP Markdown is rather limited these days. > I saw there's already support...