Michael Dolan

Results 27 comments of Michael Dolan

I can update the required checks after this merges.

Pinging this issue to resurrect it slightly, since CUDA support was discussed in this week's TSC meeting.

I've noticed this as well on Windows specifically, which is why in OCIO CI the build call is: ``` cmake --build . \ --target install \ --config ${{ matrix.build-type }}...

Noting here that some more recent commits to OCIOYaml.cpp re-introduced the `YAML::Node::GetMark()` function outside of the `OLDYAML` blocks. This function was removed in yaml-cpp 0.5.0, so breaks compatibility with yaml-cpp...

This looks good to me, but one question is whether we want to embed the header in the repo, or if we should implement our CMake pattern for optionally pulling...

Hi @andranikvfx , `ColorSpaceTransform` does support context variable expansion, so this should work. Is `SHOT_CAMERA_SPACE` static during your DCC session? You could confirm through their respective Python consoles (using PyOpenColorIO)...

It exists in `aswf/ocio-ci:2020` (which is the same digest as `2020.3` correct?). I used the above mentioned workaround to resolve it.

I think if a function is clearly named and has detailed type info it can remain succinct. If however there is any ambiguity about what a class or function does,...

@akhilsahuji the DCO check is failing because you need to sign-off your commit. The `Details` link by the check has instructions for how you can fix it: https://github.com/AcademySoftwareFoundation/OpenColorIO/pull/1632/checks?check_run_id=6056478833

Also see the commit sign-off instructions in our CONTRIBUTING document: https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/main/CONTRIBUTING.md#commit-sign-off