OpenColorIO icon indicating copy to clipboard operation
OpenColorIO copied to clipboard
verified publisher icon AcademySoftwareFoundation

Replaced "requireements" to "requirement" in installation.rst

Open akhilsahuji opened this issue 3 years ago • 7 comments

The highlighted word in the screenshot is wrong so I replaced it with the correct one. Signed-off-by: Akhil Sahu [email protected] OCIO-issue

akhilsahuji avatar Apr 17 '22 22:04 akhilsahuji

@akhilsahuji the DCO check is failing because you need to sign-off your commit. The Details link by the check has instructions for how you can fix it: https://github.com/AcademySoftwareFoundation/OpenColorIO/pull/1632/checks?check_run_id=6056478833

michdolan avatar Apr 19 '22 01:04 michdolan

Also see the commit sign-off instructions in our CONTRIBUTING document: https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/main/CONTRIBUTING.md#commit-sign-off

michdolan avatar Apr 19 '22 01:04 michdolan

@michdolan I think it should merge now.

akhilsahuji avatar Apr 19 '22 17:04 akhilsahuji

Thanks @akhilsahuji . Your commits still need a sign-off to pass the DCO check. It will require amending your commits and force pushing to your branch. Please see the Details link beside the failed check for instructions on fixing.

michdolan avatar Apr 19 '22 23:04 michdolan

Screenshot 2022-04-21 163225 Screenshot 2022-04-21 163308 @michdolan Rebased the branch and DCO check also passed it should merge now 🤞.

akhilsahuji avatar Apr 21 '22 11:04 akhilsahuji

@michdolan the DCO is now fine.

hodoulp avatar Apr 27 '22 01:04 hodoulp

@michdolan I think that the PR is now ready. Could you approve and merge this pull request?

hodoulp avatar May 04 '22 03:05 hodoulp