Michal Shalev
Michal Shalev
/azp run UCX PR
/azp run UCX PR
@iyastreb @tvegas1 please re-review
@Artemy-Mellanox @yosefe I added this: https://github.com/openucx/ucx/pull/10131/commits/420caff458f0e3b11fcdb2052c179980fc9d5fdf So we don't need https://github.com/openucx/ucx/pull/10131/commits/7d0114c3ce9a29e47484a6769551216253cac76f and https://github.com/openucx/ucx/pull/10131/commits/0e978f3f1cf17d06a34c0ebbc19c24dbe0b508a0 I can either add a commit to revert these commits or drop them and force push, please...
@Artemy-Mellanox @yosefe I reverted https://github.com/openucx/ucx/commit/7d0114c3ce9a29e47484a6769551216253cac76f and https://github.com/openucx/ucx/commit/0e978f3f1cf17d06a34c0ebbc19c24dbe0b508a0, also reverted to static array. Please re-review :)
/azp run UCX PR
@yosefe waiting for your reply on https://github.com/openucx/ucx/pull/10145#issuecomment-2404368115
I removed the "debug instructions" and squashed @yosefe
> is it possible to fix `UCS_CONFIG_TYPE_BITMAP` for sparse, instead of introducing new `UCS_CONFIG_TYPE_FLAGS`? @tvegas1 The alternative is to change UCS_CONFIG_TYPE_BITMAP instances unrelated to the flags, but it is not...
> > is it possible to fix `UCS_CONFIG_TYPE_BITMAP` for sparse, instead of introducing new `UCS_CONFIG_TYPE_FLAGS`? > > We could do it nicely by adding another "unsigned long" field to ucs_config_parser_t...