Michael Wheeler

Results 30 comments of Michael Wheeler

@DeanJayMathew Sorry, I'm not sure that I follow your meaning. Both legacy-rendered pages and MFE-rendered pages were missing at least some of the specified footer links on the Olive test...

@DeanJayMathew Got it, thanks. Yes all of your suggested modifications seem reasonable to me.

Hey @arbrandes I noticed that this has been assigned to me. Is there a specific step I am expected to take to resolve this issue?

> Does this still occur with version 1.0? FWIW I am no longer encountering this issue with 1.0.

For some context, this is related to a question that I brought up during the Tutor Users' Group about writing plugins that support multiple Tutor versions. We're currently doing something...

> Have you considered having multiple branches for your plugin, one for every major release? In our team, managing multiple branches for our plugins felt like more overhead than adding...

> You do know that you could define these variables in your own plugin by adding a callback to the `ENV_TEMPLATE_VARIABLES` filter, right? I didn't know that! It still feels...

> I think this is ready to go. Can you review it and try it out with one of your plugins? Yep, thanks! I'll try to take a look before...

Hey @kdmccormick, I tested this out and things work as expected from my perspective. Thanks!

> Would you have any objection to me removing `TUTOR_VERSION_PATCH` from this PR? No objection @kdmccormick. In practice I suspect I would only ever be using `TUTOR_VERSION_MAJOR`.