Michael Ortmann

https://github.com/eggheads/eggdrop/blob/48688f10fe406733452f9e7accb4b2a8703a5e30/src/dcc.c#L374 `set botnet-nick ""` is valid and would trigger that condition even if the bot does not support md5

Sure, gcc 10 isn't final yet, but i looked at `userent.c:838` and the compiler is right, that `old` may be NULL there. I digged into `xtra_set()` and its callers, but...

*** (BotB) -HQ has left the party line (-HQ has been forcibly removed for flooding.). *** (BotB) -HQ has joined the party line. *** (BotB) -HQ has left the party...

Missing debug log

4

Missing debug log when eggdrop is startet with `./eggdrop -nt` its missing from console until console +d can be set, which is possible only after eggdrop is fully loaded console...

Commit c64e7a70fca45ef7cc1c59158bac619c6a746dbe updated the License, which was good. But most of eggdrops source files still have an old header. For example the postal address changed: ``` $ grep -R 02110-1301...

Fix more format specifiers

1

Found by: michaelortmann Patch by: michaelortmann Fixes: One-line summary: Fix format specifier for intptr_t with c99 PRIdPTR that were shadowed by the use of egg_snprintf() and simple_sprintf() / use snprintf()...

Avoid freeaddrinfo(NULL) and enhance error logging

1

Found by: michaelortmann Patch by: Release_ Fixes: #1329 One-line summary: Avoid `freeaddrinfo(NULL)` and enhance error logging Additional description (if needed): The behavior of `freeadrinfo(NULL)` is left unspecified by RFC 3493...

Found by: michaelortmann Patch by: michaelortmann and thommey Fixes: One-line summary: Fix some year 2038 problems Additional description (if needed): Fix time_t handling (buffer size, type and format specifier) POSIX...

trace-Functions called to many times

1

I see trace-Functions and related functions called to many times, for example during startup of a bot: https://github.com/eggheads/eggdrop/tree/cbb5dad2566a2b57d6cb8574724433b80827441d/src/mod/server.mod/server.c#L1368 5 times https://github.com/eggheads/eggdrop/tree/cbb5dad2566a2b57d6cb8574724433b80827441d/src/mod/server.mod/server.c#L1330 6 times https://github.com/eggheads/eggdrop/tree/cbb5dad2566a2b57d6cb8574724433b80827441d/src/mod/irc.mod/irc.c#L1019 3 times It's not really a...

Found by: michaelortmann Patch by: michaelortmann Fixes: One-line summary: Fix typos Additional description (if needed): Test cases demonstrating functionality (if applicable):