Michael Ortmann

Fix bot_away()

2

Found by: michaelortmann Patch by: michaelortmann Fixes: One-line summary: Check return value of `partyidx` Additional description (if needed): Enhance error check and log for base64_to_int() Found by botnet fuzzing combined...

Replace atoi()

1

Currently eggdrop uses `atoi()` on some user controlled input. Those inputs should be validated. Those (or all) `atoi()` calls should be replaced by `strtol()` / `strtoul()`.

Copy module text files

3

Found by: michaelortmann Patch by: michaelortmann Fixes: One-line summary: Copy module text files Additional description (if needed): Test cases demonstrating functionality (if applicable): Tested with #1467, were we copy `src/mod/webui.mod/text/webui.html`...

Found by: thommey Patch by: michaelortmann Fixes: One-line summary: Additional description (if needed): Test cases demonstrating functionality (if applicable):

Found by: michaelortmann Patch by: michaelortmann Fixes: One-line summary: Fix copyright in main.c and misc/updatecopyright Additional description (if needed): We tried a fix of the copyright string with #1414 but...

Challenge / Response is used to mitigate sending cleartext passwords when linking bots But we dont and not use that for tls links, where the whole link is already encrypted

https://github.com/eggheads/eggdrop/blob/develop/eggdrop.conf#L7 reads `The pound signs (#)` labeling `#` as pound sign is very american. british people could think of `£`. and the rest of the world would label it number...

Same function twice. Is this intended? https://github.com/eggheads/eggdrop/blob/426f33f7a93ff665c9e19bb172d570224c5f3671/src/modules.c#L255 https://github.com/eggheads/eggdrop/blob/426f33f7a93ff665c9e19bb172d570224c5f3671/src/modules.c#L624 Here its not twice: https://github.com/eggheads/eggdrop/blob/426f33f7a93ff665c9e19bb172d570224c5f3671/src/mod/module.h#L157 https://github.com/eggheads/eggdrop/blob/426f33f7a93ff665c9e19bb172d570224c5f3671/src/mod/module.h#L521 And here code using it: https://github.com/eggheads/eggdrop/blob/426f33f7a93ff665c9e19bb172d570224c5f3671/src/mod/share.mod/share.c#L669

Found by: michaelortmann Patch by: michaelortmann Fixes: One-line summary: Dont realloc Additional description (if needed): No need to realloc. Besides the cleaning up, it will help with real world problem....

Fix runtime python version check

2

Found by: michaelortmann Patch by: michaelortmann Fixes: One-line summary: Fix runtime python version check Additional description (if needed): Test cases demonstrating functionality (if applicable):